Quote:
Originally Posted by HanSooloo
GrandpaHomer: before your next release, can you please give me a chance to incorporate your latest changes so we don't have different versions of the code out there?
My idea is to incorporate your 0.3.2 changes into a 0.4.2 and from then on go on a synchronized release schedule.
|
Indeed! I don't want to run two parallel versions as well ... :smilew
That's why it was called an interim version. I have a couple more things which I forget to mention / fix / implement in last 2 interim versions:
1. The length calculation on results.txt is incorrect! (see also bellow attached results-1.txt and resultsOK.txt for comparison). I've already amended that in my 0.3.3 version here but you can do in yours as well. Just amend the following line:
Code:
length = endaddr - straddr;
to:
Code:
length = endaddr - straddr + 1;
2. As already mentioned in 0.3.2 notes I was having problems on some systems to use
sprintf to access the drive using your formula with
hddname. It was producing incorrect device name - instead of expected
"/sys/block/sdb/size" it returned "/sys/block/sdf/sys/block//size" and indeed end up with error.
I was trying to amend that but unsuccessfully so far so I've ended with putting the fixed values back to the source on both places where the device name is "generated". Optionally - it could be sorted by using the another command line parameter to switch between the default and requested SDx device but I'd prefer to avoid that.